From: Adrian Vovk <adrianvovk@gmail.com>
Date: Tue, 20 Jan 2026 05:09:29 +0000 (-0500)
Subject: endSessionDialog: Immediately return from Open()
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~26^2~1^2~25
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=6b482e1720cb373b8a66146f16ffc9d2e49a7c52;p=gnome-shell.git

endSessionDialog: Immediately return from Open()

There's no need to wait for the dialog to finish fading in before we can
return from Open().

The code, as it was before, would break dialog updates: the dialog was
already open, so the signal would never get emitted, so the method would
never return, and so gnome-session would remain blocked waiting for a
return value that will never come.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4040>
---

diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js
index fdb0182ea..7b666f090 100644
--- a/js/ui/endSessionDialog.js
+++ b/js/ui/endSessionDialog.js
@@ -729,10 +729,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
 
         this._sync();
 
-        const signalId = this.connect('opened', () => {
-            invocation.return_value(null);
-            this.disconnect(signalId);
-        });
+        invocation.return_value(null);
     }
 
     Close(_parameters, _invocation) {